Added an error throw for setting magnet with zero length. - #435
Open
gubaidulinvadim wants to merge 1 commit into
Open
gubaidulinvadim wants to merge 1 commit into
gubaidulinvadim wants to merge 1 commit into
Conversation
Member
|
I am not sure. For which reasons we should throw an error instead of making it work with the integrated strength? |
Member
Author
|
It is so that it does not fail silently and will not confuse the user. I'd imagine you would also need the length to do the actual conversion to current. There are no thin elements in the control system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #360 by introducing a pyAMLException when the user tries to set a zero-length element.
@GamelinAl does this answer your issue?