Honour lattice_names when a linker is configured (#429) - #431
Merged
Merged
Conversation
With a linker on the simulator, Simulator.get_at_elems resolved a PyAML element only through the linker identifier built from the element name and ignored the lattice_names selector, so one PyAT element could not be driven by several PyAML elements (e.g. a serialized sextupole and the corrector coils sitting on the same thick element). - LatticeElementsLinker.get_identifier_for_name(name): identifier for a name of a lattice_names selector (implemented by the attribute linker) - Simulator.get_at_elems: with a linker, support list(a,b), [name]@i,j and [name]#a..b (bare @/# index the whole ring) through the linker - document that name refers to the linker attribute when a linker is used - tests: simulator-level selector tests on a Tag-linked lattice and the EBSNames addressing test parametrized with an equivalent linker config Fixes #429 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
JeanLucPons
approved these changes
Sep 17, 2026
Member
|
Thanks for doc clarification and fix for linker ! |
gupichon
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a linker on the simulator, Simulator.get_at_elems resolved a PyAML element only through the linker identifier built from the element name and ignored the lattice_names selector, so one PyAT element could not be driven by several PyAML elements (e.g. a serialized sextupole and the corrector coils sitting on the same thick element).
Fixes #429