Conversation
…ure-complete-magnet-holder-navigation Complete magnet holder navigation (#373)
gupichon
requested review from
GamelinAl,
JeanLucPons,
TeresiaOlsson and
gubaidulinvadim
September 17, 2026 08:03
JeanLucPons
previously approved these changes
Sep 17, 2026
2 tasks
…ure-add-a-public-tuning-and-measurement-tool-holder Add a public tuning and measurement tool holder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration PR for epic #199, ElementHolder API refurbishment. Aggregates the sub-features that split the historically monolithic ElementHolder into typed sub-holders (
.magnet(s),.bpm(s),.rf,.diagnostic,.tool, ...) reachable through Python properties, with typedget()and array access instead of the old untypedget_all*()andget_*s()list-returning methods.This branch is merged incrementally as each sub-issue lands, rather than opened as a single large PR, to keep review scoped per sub-feature.
Related Issue
Sub-issues and their status on this branch:
get_cfm()shortcut and dynamic attribute access on GenericArrayHolder based holders.masterclock.voltageis conceptually wrong,voltageneeds its own facade, acavityconcept was proposed, instead of hanging off the default RF plant. Re-opening this requires a new design, not a resubmission of Add an RF masterclock facade #427's diff.ToolHolder,tool.get(name=None), typedtune,trm,orbit,orm,chromaticity,crm,dispersionproperties with type validation. Tests added, full suite green. PR not yet opened.sr.live.bpm[...]has no wildcard support at all, and every holder disagrees on what happens when a name is missing.Changes to existing functionality
Testing
No tests added directly on this integration branch, each sub-issue's PR carries its own tests, see #426 for #373's
tests/common/test_array_holder_navigation.py, and #375's PR fortests/tuning_tools/test_tool_accessors.py.Verify that your checklist complies with the project