Skip to content

Elementholder api refurbishment - #430

Draft
gupichon wants to merge 4 commits into
mainfrom
199-elementholder-api-refurbishment
Draft

gupichon wants to merge 4 commits into
mainfrom
199-elementholder-api-refurbishment

Conversation

@gupichon

@gupichon gupichon commented Sep 17, 2026

Copy link
Copy Markdown
Member

Description

Integration PR for epic #199, ElementHolder API refurbishment. Aggregates the sub-features that split the historically monolithic ElementHolder into typed sub-holders (.magnet(s), .bpm(s), .rf, .diagnostic, .tool, ...) reachable through Python properties, with typed get() and array access instead of the old untyped get_all*() and get_*s() list-returning methods.

This branch is merged incrementally as each sub-issue lands, rather than opened as a single large PR, to keep review scoped per sub-feature.

Related Issue

Sub-issues and their status on this branch:

Changes to existing functionality

Testing

No tests added directly on this integration branch, each sub-issue's PR carries its own tests, see #426 for #373's tests/common/test_array_holder_navigation.py, and #375's PR for tests/tuning_tools/test_tool_accessors.py.

Verify that your checklist complies with the project

  • New and existing unit tests pass locally
  • Tests were added to prove that all features and changes are effective, covered per sub-PR
  • The code is commented where appropriate, covered per sub-PR
  • Any existing features are not broken

gupichon-soleil and others added 2 commits September 16, 2026 17:07
…ure-complete-magnet-holder-navigation

Complete magnet holder navigation (#373)
@gupichon gupichon self-assigned this Sep 17, 2026
@gupichon gupichon linked an issue Sep 17, 2026 that may be closed by this pull request
JeanLucPons
JeanLucPons previously approved these changes Sep 17, 2026
…ure-add-a-public-tuning-and-measurement-tool-holder

Add a public tuning and measurement tool holder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ElementHolder API refurbishment

3 participants