Repository navigation
♻️ refactor(seed): pass the build folder explicitly - #3490
Merged
Merged
Conversation
build_image pointed the installer at the staging folder and back, which needed a copy of the image path and a reset of the cached dist-info. Each build step now takes the folder and dist-info it works on, so the installer only learns the finished image path. The dist-info and console script caches go, since install now looks the dist-info up once, and the short path helper returns the folder to use instead of rebinding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3487, which merged with a build step that pointed the installer at its staging folder and back. ♻️ Seeding behaves the same: the image is still built in a staging folder and moved into place only once complete, and a failed build still leaves nothing behind.
Each build step now receives the folder and dist-info it works on, so the installer keeps one image path and learns it only once the image is in place. Before, the build kept a copy of the final path while the installer pointed at staging, and reset its cached dist-info after the move. The install step looks up the dist-info itself, so the cached dist-info, the cached console script list and the flag that guarded them are gone. On Windows, the short path lookup returns the folder to build in instead of rebinding the installer's path.