Skip to content

👷 ci(codeql): add the containment query mutant #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaborbernat merged 1 commit into from
Oct 28, 2026
Merged

👷 ci(codeql): add the containment query mutant #3485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/codeql/mutants/UncontainedMetadataDelete.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/src/virtualenv/seed/embed/via_app_data/pip_install/base.py b/src/virtualenv/seed/embed/via_app_data/pip_install/base.py
index 2fd3ac26..5347c551 100644
--- a/src/virtualenv/seed/embed/via_app_data/pip_install/base.py
+++ b/src/virtualenv/seed/embed/via_app_data/pip_install/base.py
@@ -215,7 +215,7 @@ class PipInstall(ABC):
linked: Final = entry.is_symlink()
# Unlinking the final link leaves its target intact; parent links still affect containment.
resolved: Final = entry.parent.resolve() / entry.name if linked else entry.resolve()
- if root not in resolved.parents or resolved in metadata_parents:
+ if resolved in metadata_parents:
LOGGER.warning(
"skip removal of %s listed by %s: not inside environment %s or a parent of the metadata",
entry,
Loading