Repository navigation
Conversation
Fstarnb
added a commit
to Fstarnb/PyBOP
that referenced
this pull request
Oct 13, 2026
Fstarnb
marked this pull request as ready for review
October 13, 2026 11:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #987 +/- ##
===========================================
+ Coverage 92.13% 92.94% +0.80%
===========================================
Files 74 84 +10
Lines 5799 6818 +1019
===========================================
+ Hits 5343 6337 +994
- Misses 456 481 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fstarnb
force-pushed
the
fix/898-sampling-result-chains
branch
from
October 14, 2026 13:28
560f7d5 to
5889a25
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SamplingResultchains in JSON, MATLAB, and pickle files.Fixes #898.
Validation
pytest tests/unit/test_sampling.py --unit -q— 88 passedruff check pybop/_result.py pybop/samplers/base_sampler.py tests/unit/test_sampling.pyruff format --check pybop/_result.py pybop/samplers/base_sampler.py tests/unit/test_sampling.pypython -m py_compile pybop/samplers/base_sampler.py tests/unit/test_sampling.pygit diff --check