Skip to content

Fix nightly dependencies workflow and update to use python 3.14 - #982

Merged
NicolaCourtier merged 5 commits into
developfrom
nigthly-dependencies
Oct 9, 2026
Merged

NicolaCourtier merged 5 commits into
developfrom
nigthly-dependencies

Conversation

@SarahRo

@SarahRo SarahRo commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Updates the nightly-dependencies workflow to use python 3.14 as the latest supported version of pytho.

Fixes the following issue: The workflow currently fails since the main branch of PyBaMM depends on a version of pybammsolvers that doesn't have a PyPI release.

To fix this, pybammsolvers is now also installed from the main branch of the PyBaMM repository and the relevant dependencies were added.

Successful workflow run: https://github.com/pybop-team/PyBOP/actions/runs/37931093677

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@SarahRo
SarahRo requested a review from NicolaCourtier October 8, 2026 13:51

@NicolaCourtier NicolaCourtier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sarah!

Comment thread .github/workflows/nightly_dependency_tests.yaml Outdated
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.90%. Comparing base (3171a07) to head (5042a0c).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #982      +/-   ##
===========================================
+ Coverage    92.13%   92.90%   +0.76%     
===========================================
  Files           74       84      +10     
  Lines         5799     6777     +978     
===========================================
+ Hits          5343     6296     +953     
- Misses         456      481      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SarahRo SarahRo changed the title Fix nigthly dependencies workflow Fix nigthly dependencies workflow and update to use python 3.14 Oct 9, 2026
@SarahRo SarahRo changed the title Fix nigthly dependencies workflow and update to use python 3.14 Fix nightly dependencies workflow and update to use python 3.14 Oct 9, 2026
@NicolaCourtier
NicolaCourtier merged commit 87f1bd5 into develop Oct 9, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants