fix(eigen): reject strides that are not a multiple of the scalar size - #6164
Open
henryiii wants to merge 1 commit into
Open
fix(eigen): reject strides that are not a multiple of the scalar size#6164henryiii wants to merge 1 commit into
henryiii wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
EigenProps::conformabledivided the numpy byte strides bysizeof(Scalar)with integerdivision. A stride that is not a whole number of scalars was truncated. A field of a packed
structured array (for example
np.zeros(4, dtype=[('a', 'f8'), ('b', 'i1')])['a'], which has astride of 9 bytes) was thus seen as contiguous, and a mutable
Eigen::Refread and wrote theneighbouring field.
The conformability result now records such strides. A mutable
Eigen::Refrefuses the array, andby-value and
const Refarguments copy it, as they already do for negative strides.Fixes item 5 of #6159.
Suggested changelog entry:
size, which let a mutable
Eigen::Refcorrupt neighbouring data.