Add support for diffuse IAM in the Array and PVSystem classes - #2845
Open
cbcrespo wants to merge 35 commits into
Open
Add support for diffuse IAM in the Array and PVSystem classes#2845cbcrespo wants to merge 35 commits into
Array and PVSystem classes#2845cbcrespo wants to merge 35 commits into
Conversation
…tropic_components
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
adi-IL
reviewed
Sep 2, 2026
adi-IL
left a comment
Contributor
There was a problem hiding this comment.
Signature mismatch between PVSystem.get_iam_diffuse and Array.get_iam_diffuse:
PVSystem.get_iam_diffuse accepts **kwargs and forwards them to each array:
return tuple(array.get_iam_diffuse(tilt, iam_model=iam_model,
marion_model=marion_model, **kwargs)
for array, tilt in zip(self.arrays, surface_tilt))However, Array.get_iam_diffuse does not accept **kwargs:
def get_iam_diffuse(self, surface_tilt, iam_model='marion_diffuse',
marion_model=None):Passing any optional keyword arguments to PVSystem.get_iam_diffuse raises TypeError: Array.get_iam_diffuse() got an unexpected keyword argument. Array.get_iam_diffuse should accept **kwargs and forward them to the underlying IAM model function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array.get_iam()#2812Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR adds support for diffuse component-specific IAM in the
ArrayandPVSystemclasses, laying the groundwork for its later inclusion in theModelChainclass.