Repository navigation
ci: improve FPGA file gen, fix Python black formatting - #140
Merged
Merged
Conversation
run_xilinx.sh --flist writes the license header itself, so regenerating add_sources.<board>.tcl no longer changes the tracked file. Regenerate both board files with the current Bender, which drops the stale Package comments.
The include pattern in pyproject.toml had a doubled backslash, so black matched no file and CI printed 'No Python files are present'. Fix it, exclude the submodules, and format the files it now finds with black (23.11.0 as used by rickstaa/action-black@v1, and 26.5.1 agree).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The black linter/format rules were not actually applied because of a typo in the configuration toml. This fixes it and formats the scripts accordingly.
Additionally it makes the FPGA sources scripts fully reproducible by automatically adding the header as well.