fix: restore TypeScript 6 build and Zod 4 validation errors - #64
mldangelo-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
@codex security review |
There was a problem hiding this comment.
👍 All Clear
Reviewed CI/test additions, minor TypeScript/Zod compatibility fixes in src/routes/chat.ts, and documentation updates. The PR does not change prompt construction, model routing, or agent capabilities, and introduces no new execution sinks. No LLM security issues were identified.
Minimum severity threshold: 🟡 Medium | To re-scan after changes, comment @promptfoo-scanner
Learn more
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
npm run buildfails on main with TypeScript 6's deprecatedmoduleResolution: node; once that configuration is corrected, three uses of the removed Zod 4.errorsproperty fail type checking. At runtime those paths return HTTP 500 for invalid chat requests instead of the intended structured HTTP 400.Use paired
Node16module/resolution settings (this package still emits CommonJS) and Zod's.issuesproperty. Add 23 offline chat regression/contract tests, annpm testcommand, testing docs, and Node 20/22/24 build/test CI alongside the existing security checks. This is a prerequisite repair for validating dependency PR #62; dependency versions and its bot commits stay separate.Validation:
npm ciandnpm test: 23/23 pass on Node 20.20.2, 22.23.2, and 24.21.0.References: TypeScript module resolution, Zod 4 migration.