Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromptSession(show_frame=True)loses its frame whenprompt_async()is called without ashow_frameargument. Likewise, enabling the frame in one asynchronous prompt only lasts until the next call. A session using synchronousprompt()preserves the setting across calls.Use
Noneas the default forprompt_async(show_frame=...), matchingprompt(), so omitting the argument preserves the session's boolean or filter. ExplicitTrueandFalsestill update the session for subsequent prompts.The regression tests run actual asynchronous prompts with pipe input and inspect the rendered frame corner. All three cases fail before the change and pass after it; they cover constructor settings, a
Condition, persistent overrides, and explicitly disabling the frame. The full test suite passes:uv run pytest tests/ -q(159 passed on Python 3.14.3).Related to #2011.
AI assistance: this change and its tests were developed with OpenAI Codex.