expfmt: stop a test leaving the shared parser on legacy validation - #996
Open
Rohilalala wants to merge 1 commit into
Open
Rohilalala wants to merge 1 commit into
Rohilalala wants to merge 1 commit into
Conversation
testTextParseError switched the package-level test parser between UTF-8 and legacy name validation and left it on legacy. Any later test using that parser then rejected UTF-8 names, so `go test -count=2 ./expfmt/` failed in TestTextParse, as did some -shuffle orders. Add a second shared parser for legacy validation and have testTextParseError use the two parsers as they are instead of changing their scheme. Signed-off-by: Aditya <205600203+Rohilalala@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test -count=2 ./expfmt/fails onmain, as do some-shuffleorders.testTextParseErrorswitched the package-level test parser between UTF-8 and legacy name validation and left it on legacy, so the nextTestTextParserun rejected UTF-8 names.It now uses a second shared parser for legacy validation instead of changing the scheme of the first. Neither shared parser is modified by any test now, and the benchmarks keep reusing parsers.
Not changed: some
modeltests set the globalNameValidationSchemewithout restoring it (TestLabelSetJSON,TestSilenceValidate,TestMatcherValidate, andTestDottedEncodein expfmt). None of them breaks anything today.