model: fix value-escaping round trip for runes above U+FFFFF - #995
Open
Rohilalala wants to merge 1 commit into
Open
Rohilalala wants to merge 1 commit into
Rohilalala wants to merge 1 commit into
Conversation
UnescapeName with ValueEncodingEscaping checked the 6-hex-digit limit before looking for the closing underscore, so any rune in U+100000 to U+10FFFF (e.g. "U__a_10ffff_b") was rejected and the escaped name was returned unchanged. Check for the closing underscore first; 7+ digits, surrogates and values above U+10FFFF are still rejected. Signed-off-by: Aditya <205600203+Rohilalala@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnescapeName(..., ValueEncodingEscaping)checked its 6-hex-digit limit before it looked for the closing_. So every code point that needs exactly 6 hex digits (U+100000 to U+10FFFF) was rejected, and the escaped name came back unchanged.Before:
UnescapeName("U__a_10ffff_b", ValueEncodingEscaping)returns"U__a_10ffff_b".After: it returns
"a\U0010FFFFb".7 or more digits, surrogates and values above U+10FFFF are still rejected. This affects callers that unescape
U__names, such as Prometheus's label values API and Pushgateway grouping keys when UTF-8 names are enabled.Not changed: legacy-valid names that already start with
U__(e.g.U__foo) are not escaped byEscapeName, so they unescape tofoo.