Repository navigation
InviteScreen: show details immediately to avoid jumps - #1209
Merged
kevinaboos merged 1 commit intoOct 25, 2026
Merged
Conversation
we already had almost all the details when first swhoing the invite, so we don't actually need to fetch the full room summary. But we do need that for member count and join rule. This avoids the UI jumping around, which is one of my pet peeves. The accept/reject invite buttons were getting pushed down as the extra room info loaded. now that's all fixed and it doesn't jump around. During the process we also fixed a few other minor issues: * the accept and reject buttons wrap if the screen is too narrow * the join rule and member count also wrap * the whole topic is visible in full now, but initially shown collapsed with line breaks converted to spaces. previously it was just ellipsized & truncated after a few lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we already had almost all the details when first swhoing the invite, so we don't actually need to fetch the full room summary. But we do need that for member count and join rule.
This avoids the UI jumping around, which is one of my pet peeves. The accept/reject invite buttons were getting pushed down as the extra room info loaded.
now that's all fixed and it doesn't jump around.
During the process we also fixed a few other minor issues: