Repository navigation
pytest: let either HTLC claim reveal the preimage in test_onchain_middleman_fulfill_after_fail - #69
Merged
Conversation
…dleman_fulfill_after_fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_onchain_middleman_fulfill_after_failwaited for one specific HTLC-success txid. l3 claims two HTLCs with the same preimage, and both claims take their fee from l3's only wallet UTXO. When the HTLCs' deadlines differ, their claims target different feerates and only the higher one stays in the mempool, so the test timed out whenever it was waiting on the other. This failed every run in the Knots backend job.The test now mines a block between the two HTLCs so their deadlines always differ, and mines once either claim is in the mempool, since either reveals the preimage to l2.
Tested: the old test fails locally with the extra block, with the same feerates and rejection as CI. The new test passes 6 of 6 against the pinned Knots backend.
Changelog-None