Repository navigation
Verify and safely activate Pop toolchain bundles - #2
Merged
Merged
Conversation
Require exact release assets and matching SHA-256 metadata before\nextraction. Reject unsafe or incomplete archives, install\ntransactionally, preserve custom POPUP_HOME shims, and use uname -m\nfor portable Linux architecture detection.
Require the target-specific language server in every verified bundle and expose it through a popup-managed shim. This keeps editor tooling on the selected compiler release instead of relying on a source checkout or PATH accident.
GalactHD
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden
popuptoolchain installation so a release is verified before it can become active.The installer now selects exact target assets, requires matching SHA-256 metadata, validates the checksum filename and digest, rejects unsafe or incomplete ZIP archives, and activates complete toolchains transactionally. The setup path also respects a custom
POPUP_HOME, and Linux target detection usesuname -mrather than the non-portableuname -iresult.Security and architecture
pop-<target>.zipand its exact.sha256asset.bin/pop,lib/libpop_standard.a, andlib/libpop_runtime_native.a.$HOME/.popup.Verification
crystal tool format --check src speccrystal run src/popup.cr --no-codegencrystal spec(17 examples, 0 failures)bin/ameba(13 files, 0 failures)shards build popuppop checkandpop runsmoke testsReview notes
The checksum is obtained from the same GitHub release as the archive. This protects against corruption and asset substitution but is not a signed-release or independent trust-root design; release signing remains a separate architectural decision.