fix(touch): reveal Home cards from the left during minimization - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Home-bar swipe during the preceding app's minimization could reuse that app's shrinking icon pose, making Photos grow from its Home icon. Prepare a fresh reveal off the left edge at card size. Preserve visible poses only when catching an already prepared, withdrawing left-edge peek.
Validation:
bun run check:touch: typecheck, 48 Bun tests / 7,228 assertions, and 7 Python protocol tests pass.Native E7 validation:
viewport=360×640, andinactive_frames=0.09abb482a216e47c9d91beffab4ed0b585261641f930961d768a082fd916d0f9.p2039after MTP byte-for-byte readback and CODA package verification. Replay input is empty and the temporary wake helper has been uninstalled.0e62191452ae600d5fce2e68ac35c8436d63692373498b4ff7804abd98c5df04; tracing disabled, 60 Hz, VFPv2. Guest SHA-256:132a49a7c2bef51ab4b6ee86e81b281c71da2ebe9567cdd617b5d3fdc1f0a423.2453d60cand the same optimized native core as the preceding E7 deployment. Shared navigation is tested at iPod dimensions; this run's native device validation is E7, not iPod.Reproduce from the PocketJS runtime checkout:
For inspection, build with
--perf-traceand use the shell's CODA profile command with a packed contact sequence that returns Photos Home and starts a bottom-bar reveal 200 ms later. Replay checks native guest dispatch and rendering; physical touch delivery remains a manual acceptance boundary. Per-run packages, traces and screenshots stay in ignored.pocket-build/validation/touch/home-reveal-left/and the upstream build checkout's validation directory.Stacked on #18; no runtime or vendor pin changes.