Repository navigation
Fix vulnerable QuickBooks example dependencies and migrate to OAuth 2.0 - #27
Merged
Merged
Conversation
robgilbreath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QuickBooks example installed vulnerable EJS and an obsolete public SDK whose request dependency introduced additional vulnerabilities. It now uses patched, separately locked example dependencies and the SDK in this checkout, with an OAuth 2.0 authorization-code flow using Node fetch. Session state binds the callback, replay is rejected, and tokens are never logged or rendered.
CI installs, tests, and audits the example separately. The SDK patch version advances to 2.0.58 to satisfy the publication gate.
Validation: reproducible root/example npm ci, four SDK regression tests, typecheck, four loopback example tests covering state validation, OAuth exchange, escaping, replay and failure handling, and zero audit findings in both dependency trees. An independent agent reviewed the final change. Live Intuit authentication requires user credentials and was not exercised.