Skip to content

Fix tag item association - #372

Open
Herafia wants to merge 12 commits into
mainfrom
fix/tag-associate-item
Open

Fix tag item association#372
Herafia wants to merge 12 commits into
mainfrom
fix/tag-associate-item

Conversation

@Herafia

@Herafia Herafia commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !45879
  • Assigning an item to a tag from the tag's details page no longer worked, without generating an error.

Regression : The file front/tag.form.php, which handled this association, had been accidentally deleted in an unrelated commit. The request was then processed by the generic mechanism, which created a tag instead of establishing the association.

Fix : re-enable correct processing of the tag/item association.

Screenshots (if appropriate):

image

@Herafia
Herafia force-pushed the fix/tag-associate-item branch from 4024518 to e9c3d61 Compare August 21, 2026 10:36
@Herafia
Herafia force-pushed the fix/tag-associate-item branch from e9c3d61 to 569201f Compare August 21, 2026 13:12
@Herafia
Herafia force-pushed the fix/tag-associate-item branch from 2b655a6 to 0a31762 Compare August 21, 2026 13:42
@Herafia
Herafia requested review from Rom1-B and stonebuzz August 21, 2026 13:51
@Herafia Herafia self-assigned this Aug 21, 2026
Comment thread inc/tagitem.class.php Outdated
@Herafia
Herafia requested a review from stonebuzz August 24, 2026 10:22
Comment thread tests/Units/TagItemTest.php Outdated
Comment thread tests/TagTestCase.php Outdated
@stonebuzz
stonebuzz requested a review from Rom1-B August 27, 2026 09:23
Comment thread tests/Units/TagItemTest.php

@Rom1-B Rom1-B left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@Herafia
Herafia requested review from Rom1-B and stonebuzz August 28, 2026 13:56
Comment thread src/Controller/TagItemController.php Outdated
Comment thread src/Controller/TagItemController.php
Comment thread inc/tagitem.class.php Outdated
Comment thread inc/tagitem.class.php Outdated
Herafia and others added 5 commits September 4, 2026 16:15
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants