Skip to content

FIX / Admin locks himself out of a container's configuration #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mary-Clb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FIX / Admin locks himself out of a container's configuration #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1f1ffd
use config right to access container config form
Mary-Clb Sep 3, 2026
8ef01d0
update CHANGELOG.md
Mary-Clb Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Fixed

- Fix administrators losing access to a block's configuration after setting a profile to "no access" on that block.

## [1.24.4] - 2026-08-06

### Fixed
Expand Down
11 changes: 3 additions & 8 deletions front/container.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
* -------------------------------------------------------------------------
*/

use Glpi\Exception\Http\AccessDeniedHttpException;

Session::checkLoginUser();

if (empty($_GET['id'])) {
Expand Down Expand Up @@ -63,12 +61,9 @@
Html::back();
} else {

if ((int) $_GET['id'] > 0) {
$right = PluginFieldsProfile::getRightOnContainer($_SESSION['glpiactiveprofile']['id'], $_GET['id']);
if ($right < READ) {
throw new AccessDeniedHttpException();
}
}
// Admin config screen: gate with the standard "config" right, not the per-profile
// block-visibility right (which would let an admin lock himself out of the config).
$container->check((int) $_GET['id'] > 0 ? (int) $_GET['id'] : -1, READ);

Html::header(
__('Additional fields', 'fields'),
Expand Down