Skip to content

Preserve native popup wait errors - #177

Open
smnandre wants to merge 1 commit into
playwright-php:mainfrom
smnandre:fix/popup-error-propagation
Open

smnandre wants to merge 1 commit into
playwright-php:mainfrom
smnandre:fix/popup-error-propagation

Conversation

@smnandre

Copy link
Copy Markdown
Member

Page and context popup waits currently turn native failures into a generic timeout. Preserve the original error message and name through callback coordination so actual timeouts remain TimeoutException and other failures retain their cause.

Observe popup promise rejections while PHP runs its callback to prevent an early timeout or closure from terminating the Node bridge. Release pending PHP callbacks on both success and failure.

Refs #173

@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Transport/JsonRpc/JsonRpcTransport.php 96.15% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant