Repository navigation
Frame properties disappeared (possible regression) #52
Description
As per this forum post by FranceBB
https://forum.doom9.org/showthread.php?p=2027669#post2027669
the frame properties has been killed and are not getting passed over.
I think this commit, which replaced make_writeable with a manual frame copy, did it.
716df2f
avs_make_writable(p->env, &src); makes a complete content copy if needed, and preserves frame properties of source.
Unlike dst = avs_new_video_frame_a(p->env, &p->vi, AVS_FRAME_ALIGN);
Which kills them.
However avs_new_video_frame_p_a has a source frame property parameter, but since I don't know why avs_make_writable was replaced, I recommend it only if we really have to use avs_new_video_frame_xx construct.
@seiya-git:
Why did you make manual copy, since make_writeable is doing exactly the same. I remember making a comment on it.
Activity
seiya-git commentedon Jan 31, 2026
For some reason, avs_make_writable triggered bug: #49 (comment)
PR #53 should fix it
seiya-git commentedon Jan 31, 2026
@FranceBB you can test this build: assrender_bin_win.zip
seiya-git commentedon Jan 31, 2026
@realfinder, can u also test this build with your tests?
assrender_bin_win.zip
realfinder commentedon Feb 1, 2026
seems ok with the old tests I have, also the frame properties copied now
seiya-git commentedon Feb 1, 2026
@realfinder thanks, then better use avs_copy_video_frame + avs_make_writable
PR updated
seiya-git commentedon Feb 1, 2026
@pinterf can u look PR #53 and #54 please ?
pinterf commentedon Feb 1, 2026
Thanks, yes, will check it tomorrow. And I have to re-check the makewritable problem since things must work with it (I did not check it more deeply yet, neither your recent fixes, I'm not near my PC)
pinterf commentedon Feb 2, 2026
@realfinder
https://drive.google.com/uc?id=1NotIP-9NGTwiguElDxyUS7yxQBam6jr9
Could you please check this version? Thanks.
I'm using a simple avs_make_writable, which - theoretically - must work.
realfinder commentedon Feb 2, 2026
with this script #49 (comment) seems work fine
edit: maybe it was avspmod display problem/settings in the first place?
FranceBB commentedon Feb 15, 2026
Thanks for the fix guys and for reinstating avs_make_writable, I can confirm that version 0.37 fixes the issue and frame properties are now correctly preserved. :)
Fix pinterf#52: revert to single avs_make_writable