Skip to content

fix(desktop): make snapshot extension enable idempotent #11630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AKolenda wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix(desktop): make snapshot extension enable idempotent #11630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/desktop/src/snapShot/GnomeCaptureSetup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ it("enables and disables only the capture UUID", async () => {
setup.close();
});

it("treats enabling an already active extension as success", async () => {
const { setup, call } = fixture({ state: 1, version: 2 });
await expect(setup.perform("enable-extension")).resolves.toBeUndefined();
expect(call.mock.calls.map(([message]) => message.member)).not.toContain("EnableExtension");
setup.close();
});

it("never changes the global user-extensions preference", async () => {
const { setup, call } = fixture({ state: 2, version: 2, enabled: false });
await expect(setup.perform("enable-extension")).rejects.toThrow("GNOME has disabled");
Expand Down
1 change: 1 addition & 0 deletions apps/desktop/src/snapShot/GnomeCaptureSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ export class GnomeCaptureSetup {
// GNOME discovers a newly installed local extension at the next login.
return;
}
if (action === "enable-extension" && state.status === "enabled") return;
if (action === "enable-extension" && state.status !== "disabled")
throw new Error(state.message);
const result = await this.call({
Expand Down
Loading