fix(mobile): render markdown in question cards - #11612
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized one-file mobile bug fix that applies the existing Markdown renderer to question-card content while preserving selection, submission, and data behavior. It does not modify product defaults, schemas, sensitive areas, deployment configuration, or static-analysis settings. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07dba53c34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Markdown theme={inlineMarkdownTheme}> | ||
| {question.question} | ||
| </Text> | ||
| </Markdown> |
There was a problem hiding this comment.
Preserve angle-bracket placeholders when rendering Markdown
When a provider asks a question containing a placeholder such as Choose the <branch-name> to deploy, the Markdown parser classifies <branch-name> as html_inline, but the library's default renderer does not render HTML nodes. The placeholder therefore disappears from the question; the same regression affects the newly wrapped option labels and descriptions. Add HTML-node handling that preserves or normalizes their text instead of relying on the default renderer.
Useful? React with 👍 / 👎.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe mobile pending user input card now renders questions, option labels, and descriptions as Markdown. A memoized inline theme applies appearance preferences, theme colors, platform fonts, typography, spacing, and code styling. ChangesPending input Markdown rendering
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: 🟡 Moderate · up to Pending-input Markdown can handle links and images differently from existing thread content, including bypassing the established asset-safety policy. Reuse that policy before merging. 🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (1 passed)
Full details: Linked Issues checkExplanation Issue Resolution Implement the Full details: Out of Scope Changes checkExplanation The PR adds Markdown rendering to
✨ Finishing Touches 💡 2⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Question text, option labels, and option descriptions in PendingUserInputCard were rendered as raw Text without any markdown processing. Wrapped all three with the Markdown component from react-native-nitro-markdown using a compact inline theme consistent with ThreadFeed patterns.
Fixes #11132
Summary by CodeRabbit