fix(mobile): prevent overlapping text and UI on Android chat messages - #11611
fix(mobile): prevent overlapping text and UI on Android chat messages#11611Exotic209093 wants to merge 1 commit into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
vouch:unvouched
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused Android/mobile rendering fix that constrains markdown layout and preserves fixed-size icons to prevent chat text and controls from overlapping. It changes only localized presentation behavior and introduces no schema, security, billing, infrastructure, or product-default changes. You can add or adjust custom eligibility rules. Learn more. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a38624ba75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // bubbles: wide markdown blocks cause children to be positioned at | ||
| // intrinsic width before the container is clamped, overlapping the | ||
| // timestamp/copy button row. Pinning the width removes that pass. | ||
| const assistantHasWideBlock = hasWideMarkdownBlock(message.text, WIDE_MARKDOWN_BLOCK_OPTIONS); |
There was a problem hiding this comment.
For every assistant-message render, this repeats the identical hasWideMarkdownBlock call already made in hasWideBlock above. On Android, ordinary long messages without an early match make the helper split and scan the entire message twice; while an assistant response is streaming, that redundant linear work and allocation recurs on every update in the performance-sensitive feed. Use the existing hasWideBlock value for the assistant width condition instead.
AGENTS.md reference: AGENTS.md:L15-L17
Useful? React with 👍 / 👎.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe mobile thread feed prevents inline icons from shrinking, contains wide markdown list content, and pins assistant rows with wide blocks to full width. ChangesAndroid message layout
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Android chat layout changes address the reported overlap paths without an established regression; the PR is mergeable. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
1 participant
Assistant message containers had no width constraint, so Android Yoga unclamped-pass layout caused timestamps and copy buttons to overlap message text. List item content columns also lacked flexShrink, letting favicon icons bleed into text. Applied the same hasWideMarkdownBlock width-pinning already used for user bubbles, added flexShrink and overflow hidden to list content, and pinned favicon images to fixed size.
Fixes #11119
Summary by CodeRabbit