Skip to content

Support negative lags in RV calculation #35

Description

@tsalo

Detailed Description

Currently, only positive lags are supported in RV calculation:

delays = [abs(int(lag * samplerate)) for lag in lags]

However, apply_lags() supports negative lags just fine.

Context / Motivation

I require this for an analysis, and there is no real cost. In fact, as it is implemented, it could be confusing for users.

Possible Implementation

I think it's pretty straightforward to fix:

    delays = [int(lag * samplerate) for lag in lags] 

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions