ext/ftp/tests: add with_data_connection to mock server - #23455
Open
Sjord wants to merge 7 commits into
Open
Conversation
Sjord
force-pushed
the
cleanup-ftp-server-inc
branch
from
August 25, 2026 15:56
47c5a80 to
817ea85
Compare
FTP is a line-oriented protocol, so fgets is better.
Sjord
marked this pull request as ready for review
August 29, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FTP uses separate control and data connections. Extract setting up the data connection to a separate function. This was duplicated many times throughout the test server.
Also use fgets instead of fread, because that matches FTP's line-based protocol better.