Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 25 additions & 21 deletions .github/workflows/check-en-revision.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# https://docs.github.com/en/actions
# Checks that the EN-Revision comment of the .xml files changed in a PR points to
# the latest doc-en commit for that file. Emits a ::error annotation and fails if
# the hash is missing, wrong, from another file, or outdated.
# Checks that the EN-Revision tag of the .xml files changed in a PR matches
# the latest commit hash of the corresponding doc-en file. The script emits
# its own ::error annotations.
#
# The script is the one from doc-base, shared by all translations, and no
# longer an inline bash snippet local to this workflow.

name: "Structure"

Expand All @@ -18,36 +21,37 @@ jobs:
name: "Check EN-Revision"
runs-on: ubuntu-latest
steps:
# The explicit ref takes the real head of the pull request, not the merge
# commit actions/checkout builds by default: that one has master as its
# second parent, so the diff below would also list every file landed on
# master since the last push to the pull request.
# ru/, en/ and doc-base/ side by side: this is the layout expected by
# the doc-base scripts, the same as the one the build workflow uses. The
# explicit ref takes the real head of the pull request, not the merge commit
# actions/checkout builds by default: that one has master as its second
# parent, so the diff below would also list every file landed on master
# since the last push of the PR.

- name: "Checkout translation"
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
path: ru
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0

- name: "Checkout php/doc-en"
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
path: en
repository: php/doc-en
fetch-depth: 0

- name: "Checkout php/doc-base"
uses: actions/checkout@v7
with:
path: doc-base
repository: php/doc-base

- name: "Check EN-Revision"
run: |
BASE="${{ github.event.pull_request.base.sha }}"
git fetch --no-tags --depth=1 origin "$BASE"
fail=0
while IFS= read -r f; do
[ -f "$f" ] && [ -f "en/$f" ] || continue
declared=$(grep -oiP 'EN-Revision:\s*\K[0-9a-f]+' "$f" | head -1 || true)
latest=$(git -C en log -1 --format=%H -- "$f")
if [ "$declared" != "$latest" ]; then
echo "::error file=$f::EN-Revision ${declared:-missing} != latest doc-en commit $latest"
fail=1
fi
done < <(git diff --name-only "$BASE"...HEAD -- '*.xml')
exit $fail
git -C ru fetch --no-tags --depth=1 origin "$BASE"
git -C ru diff --name-only "$BASE"...HEAD -- '*.xml' \
| php8.3 doc-base/scripts/translation/check-en-revision.php \
--lang=ru --github
Loading