Repository navigation
Trim the S-100 backslashes from the subfield label before a repeating group - #39
Merged
Merged
Conversation
… group S-100 Part 10a data descriptive records put "\\" just before the '*' that starts a repeating group, as in the S-101 2.0 DSID descriptor "...!DSAB!DSED\\*DSTC". The reader kept the backslashes in the name of the subfield before the '*', so DSED, IUIN, VCID and FAUI were named "DSED\\" and so on, and lookups by name missed them. Trailing backslashes are now trimmed from every subfield label, in both the labels-section and descriptor parsing paths. Reader tests cover the S-101 2.0 DSID and C3IL descriptors. No public API changes. Fixes #38
3.1.8 has a moderate advisory (GHSA-qhrr-8q5h-9q3h, nested arrays can exceed buffer length limits), and restore treats the NU1902 warning as an error, so every CI build failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S-100 Part 10a data descriptive records put "\" just before the '*'
that starts a repeating group, as in the S-101 2.0 DSID descriptor
"...!DSAB!DSED\DSTC". The reader kept the backslashes in the name of
the subfield before the '', so DSED, IUIN, VCID and FAUI were named
"DSED\" and so on, and lookups by name missed them.
Trailing backslashes are now trimmed from every subfield label, in both
the labels-section and descriptor parsing paths. Reader tests cover the
S-101 2.0 DSID and C3IL descriptors.
No public API changes.
Fixes #38
Once this ships, the backslash workaround in
S101DocumentReader(philliphoff/EncDotNet.S100#1137) can be removed.