[nadorator]

Hello!

• Type: bug fix
• Link to issue: [BUG]: Model keeps a default id of 0 after insert on MySQL since 5.12 (lastInsertId() skipped) cphalcon#17689 (mirror of [#17689] - read back the generated id when the identity is 0 on adapters without sequences cphalcon#17690)

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:

Port of phalcon/cphalcon#17690. Model::doLowInsert() reuses any non-empty identity value instead of calling lastInsertId() (fix for #16436). On MySQL, 0 is not an explicit id: MySQL replaces it with the next auto-increment value, so a model whose identity property is 0 keeps 0 after save() / create().

The value on the model is now reused on adapters with sequences (as before) and for any explicit non-zero value. Only 0 on adapters without sequences goes through lastInsertId(), which returns the stored id (the generated one on MySQL, 0 on SQLite). The PostgreSQL behaviour from #16436 is unchanged. supportSequences() is now called once and stored in $useSequences.

Tests (tests/database/Mvc/Model/CreateTest.php), same as in cphalcon:

• testMvcModelCreateWithZeroIdentityMysql (data sets 0 and '0'): the model gets the id stored in the table.
• testMvcModelCreateWithZeroIdentitySqlite (data sets 0 and '0'): 0 is stored as given and read back as the string '0'.
• testMvcModelCreateWithExplicitIdMysqlSqlite: an explicit 77 is kept as int 77.

Checked locally with PHP 8.2.35: CreateTest sqlite OK (5 tests, 18 assertions), mysql/MariaDB 10.6 OK (5 tests, 20 assertions); phpcs and phpstan pass on the changed files.

Thanks

🤖 Generated with Claude Code

[niden]

Thank you @nadorator