ci: let workflow_dispatch actually deploy docs, rename to "Docs Publish" - #102
Open
petercorke wants to merge 1 commit into
Open
ci: let workflow_dispatch actually deploy docs, rename to "Docs Publish"#102petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
docs.yml already had a workflow_dispatch trigger, but the Pages-artifact upload and the deploy job were both gated on github.event_name == 'push', so a manual run silently built the docs and threw the result away without publishing anything. Widens both to also allow workflow_dispatch, and adds an explicit ref check on deploy (dispatch can target any branch, push is already restricted to main via the branches: filter). Also renames the workflow to "Docs Publish" to match the same button across RTB/MVTB/bdsim.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs.ymlalready listedworkflow_dispatchas a trigger, but theupload-pages-artifactstep and thedeployjob were both gated ongithub.event_name == 'push'— a manual run silently built the docs and threw the result away without publishing. Widens both guards to also allowworkflow_dispatch.github.ref == 'refs/heads/main'check ondeploy, sinceworkflow_dispatch(unlikepush, already restricted viabranches: [main]) can be run against any branch — a manual dispatch from a feature branch now builds but doesn't publish.Test plan
mainstill builds + deploys docs, same as beforemainand confirm it now actually deploys