Repository navigation
chore(deps): bump Microsoft.Playwright to 1.64.1 - #302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
PlaywrightVersionfrom 1.52.0 to 1.64.1 (affects bothMicrosoft.PlaywrightandMicrosoft.Playwright.MSTest).Why
Playwright 1.52.0 bundles a Chromium build predating the Chrome 156.0.8078.73 security release, which fixes four Critical CVEs:
Caveat worth knowing
1.64.1 bundles Chromium 156.0.8078.4, still below the 156.0.8078.73 fix line. This bump moves off an older Chromium but does not fully remediate those CVEs on its own. Full remediation needs
Channel = "chrome"(system Chrome) or Playwright 1.65+ (bundles 158.0.8127.2).I deliberately did not add
Channel = "chrome":pr_validation.yamlcaches~/.cache/ms-playwrightkeyed onPlayWrightVersion, so switching to system Chrome would break the E2E job unless the runners also provision Chrome.Verification
dotnet restoresucceeds;project.assets.jsonresolvesMicrosoft.Playwright/1.64.1inDrawTogether.End2End.Tests.