Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR "replaces"
Table::validate_expressionswithTable::describe, which validates a completeViewConfigagainst a table and reports the schema aViewbuilt from it would have, without creating one. The old call could only type-check expressions in isolation; everything else about a config (bad column names, bad windows, bad aggregates) only surfaced by building aViewand catching the failure.The actual
Table::validate_expressionsmethod still exists, so this change is only breaking in the sense that the Virtual Server API now requires implementingdescribeinstead of justvalidate_expressions. Internally however, it now creates an entire blankViewConfigto host the expressions.For a config like:
Expect one of these return values:
{ expression_schema, view_schema }view_schemaequals View::schema() of the same config{ expression_schema, expression_errors }{ config_error }In addition to
perspective-server, all virtual servers have been updated and dedicated tests added.