Repository navigation
Feat/platform progress: osx build - #2
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 527cbad228
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| OperatingSystem.IsMacOS() ? new MacDockProgress() : new LinuxLauncherProgress()); | ||
| private static readonly PlatformProgressGroup ApplicationGroup = new( | ||
| () => OperatingSystem.IsMacOS() ? new MacDockProgress() : new LinuxLauncherProgress(), | ||
| keepBackendWhenIdle: OperatingSystem.IsLinux()); |
There was a problem hiding this comment.
When the first Linux progress operation starts while the session bus is temporarily unavailable or ConnectAsync fails, LinuxLauncherProgress permanently stores a completed task containing null. Retaining that backend while idle means every later operation reuses the failed instance and can never display launcher progress; previously, finishing the operation disposed it so the next operation attempted a new connection. Retain only a successfully connected backend, or make the Linux backend retry failed connections.
Useful? React with 👍 / 👎.
1 participant
No description provided.