feat: unseal Backend behind a custom-backend feature - #2279
Open
DenzelPenzel wants to merge 1 commit into
Open
DenzelPenzel wants to merge 1 commit into
DenzelPenzel wants to merge 1 commit into
Conversation
The Backend trait is sealed by default. Enabling the new custom-backend feature unseals it so that external crates can provide their own Backend implementations, at the cost of the trait's stability guarantees. A UI test pins the sealed-by-default behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #2273 per review. The
Backendtrait is sealed, so external crates cannot provide their ownBackendimplementations. Enabling the newcustom-backendfeature unseals the trait, at the cost of its stability guarantees (new required methods may appear in minor releases).The feature is named
custom-backendrather thanunstable-backend, since the latter was the historic name of the chain-head backend feature.Implementation
custom-backendfeature flag on thesubxtcrate; without it the trait stays sealed.Backendexternally with the feature enabled.