Repository navigation
Leave UltraSpeedBoost off at startup; boost Ultrafast playback per run - #13
Open
s1f102500012 wants to merge 1 commit into
Open
s1f102500012 wants to merge 1 commit into
s1f102500012 wants to merge 1 commit into
Conversation
… run The flag is process-wide, so enabling it at startup also changed speed 4 for normal play and for mods that mirror vanilla's boost branch. play_for and play_until_letter now enable it for Ultrafast (or forceRequestedSpeed) runs and restore the previous value afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With RimBridgeServer installed,
TickManager.UltraSpeedBoostis switched on at startup and stays on, so speed 4 changes for normal play too: vanilla Ultrafast jumps to the debug rate, and mods that mirror vanilla's boost branch (e.g. Smart Speed, where a configured 15x becomes 150x) multiply their own rate. Players who only have the mod installed for occasional agent sessions see this without asking for it — similar to the camera zoom extension in #4.This keeps the boost for automation but scopes it to the runs that need it:
RimBridgeStartupno longer setsUltraSpeedBoost.play_forandplay_until_letterturn the boost on when the requested speed isUltrafast(orforceRequestedSpeedis set) and restore the previous value afterwards, including on the failure path. Other speeds leave the flag untouched.set_time_speedwithultraSpeedBooststill sets it explicitly for the session.docs/tool-reference.mdand the README tool surface are regenerated.Testing:
scripts/build-mod.sh --test: build ok, 212 tests pass.UltraSpeedBoostright after startupplay_forNormal, 1.5 splay_forUltrafast, 1.5 sset_time_speedwithultraSpeedBoosttrue/falseThe live check ran on the RimWorld 1.7 unstable branch (that is the build I have locally), not on 1.6.