Skip to content

fix: an observer told a tunnel closed could still see its session open - #8

Merged
Michael McQuade (giraffesyo) merged 2 commits into
canaryfrom
fix/close-order-and-gate-multiplicity
Oct 14, 2026
Merged

Michael McQuade (giraffesyo) merged 2 commits into
canaryfrom
fix/close-order-and-gate-multiplicity

Conversation

@giraffesyo

Copy link
Copy Markdown
Member

Three fixes surfaced by the first CI run on canary after #6.

  • A tunnel's session is removed before the tunnel is reported closed, so an observer never sees a closed tunnel's session still open. TestRevocationClosesTunnel now samples the registry inside TunnelClosed, which fails every time without the fix (it was racy before).
  • The benchmark gate tested about 30 comparisons each at p < 0.05, so roughly one in three runs failed on noise: the canary run failed on the unchanged WebSocket baseline (p = 0.043). Significance is now judged per family of comparisons with Holm's step-down procedure, which bounds the chance of any false failure at 5%. A real regression still fails (10 against 10 samples separate at p ≈ 1e-5).
  • release-please starts a repository with no release at 1.0.0 regardless of the manifest. initial-version makes the first release v0.1.0, as the plan says; release-please release-pr --dry-run against this branch proposes 0.1.0.

@giraffesyo
Michael McQuade (giraffesyo) merged commit aa82e69 into canary Oct 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant