Repository navigation
perf(ui): make app frame navigation styles optional - #516
Merged
Michael McQuade (giraffesyo) merged 1 commit intoOct 25, 2026
Merged
Conversation
Michael McQuade (giraffesyo)
deleted the
perf/app-frame-css-entrypoints
branch
October 25, 2026 04:31
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applications with custom navigation currently load the styles for
AppFrameNavItemeven when they never render it. Export@parallelworks/ui/app-frame/layout.cssfor the frame, resize handle, toggle/close buttons, focus indicators, and mobile drawer, and@parallelworks/ui/app-frame/navigation.cssfor the optional navigation items.The existing
@parallelworks/ui/app-frame.cssimport continues to include both. The published combined file remains self-contained, so direct stylesheet links do not gain additional requests. All rules retain thepw-uilayer. No component runtime or dependency changes.Measured with Vite's production CSS build and gzip:
Layout-only consumers omit 1,096 minified bytes / 297 gzip bytes compared with the previous combined stylesheet, about 20% of its compressed size. These are isolated stylesheet measurements, not a whole-application bundle estimate.
Testing
verify:packinstalls the actual tarball and bundles all CSS import forms. It checks that combined and separate imports produce identical output, layout-only omits navigation item styles, and the compatibility file has no import waterfall. Existing runtime-import and consumer-type checks also pass.Existing frame: before and after
Custom navigation with layout CSS only
layout-only-interaction.mp4
Checklist
make checkwas not run locally because this changes only the UI package.