Repository navigation
feat(ui): on a phone a list's search takes the whole header bar, and the header never lets its actions overlap the breadcrumbs - #514
Merged
Michael McQuade (giraffesyo) merged 3 commits intoOct 24, 2026
Conversation
…the header never lets its actions overlap the breadcrumbs
Contributor
Dependency graph benchmarkMedians of 3 runs in headless Chrome on a shared runner; lower is better. Base and head run in turn on the same machine. thousand
three-thousand
nested
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps now put a list's controls (a
ListToolbarwith view, filter and search) inPageHeader'sactions, so the count can sit under the rows. On a phone, opening that search painted a fixed 288px field over the sidebar toggle, the breadcrumbs and the other controls.What changes
PageHeaderActionfolded into "…". It uses the same measurement as the actions' fit, not a breakpoint. If the field wouldn't fit, the open search fills the bar from its start to its end. The trail, title actions and other controls stay laid out underneath,invisibleandinert, so closing restores the bar exactly. On a wide bar the field still opens in place./or Mod+F) moves focus into the field, which keeps its accessible name. Closing with Escape or × returns focus to the search button. This also applies to a search opened in place, which used to drop focus to the page.list.searchActivestring). Elsewhere the terms keep the field open, as before.PageHeaderActions and "+ Add" fold into "…" before the controls reach the trail, and the trail folds to the current page first. AListToolbar's icons are never folded.Screenshots
UI/List/Page › Controls in the header(new story): breadcrumbs, aListToolbar, "Edit allocations" and "+ Add" inactions.Phone (390px), search open with a query
Phone (390px), search closed (unchanged)
Desktop, the field opens in place (unchanged)
Tests
src/list/headerSearch.dom.test.tsx, with a measured bar: