Skip to content

Post full exception context - #3

Merged
nakulj merged 12 commits into
mainfrom
error-message-exception-chain
Oct 8, 2026
Merged

nakulj merged 12 commits into
mainfrom
error-message-exception-chain

Conversation

@nakulj

@nakulj nakulj commented Oct 7, 2026

Copy link
Copy Markdown

Background

slash throws away all the context behind an exception

Description

make slash not do that

Verification

unit tests

@nakulj
nakulj requested a review from ps-groscoe October 7, 2026 18:38
@nakulj nakulj changed the title Error message exception chain Post full exception context Oct 7, 2026
Comment thread slash/core/error.py
Comment thread slash/core/error.py
Comment thread slash/core/error.py Outdated
@nakulj
nakulj force-pushed the error-message-exception-chain branch from d88d279 to 921ac13 Compare October 7, 2026 23:14
@nakulj
nakulj changed the base branch from main to replace-emport October 7, 2026 23:14
@nakulj
nakulj added this pull request to stack #5 October 7, 2026 23:19
ps-groscoe
ps-groscoe previously approved these changes Oct 8, 2026

@ps-groscoe ps-groscoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from replace-emport to main October 8, 2026 18:25
@nakulj
nakulj dismissed ps-groscoe’s stale review October 8, 2026 18:25

The merge-base changed after approval.

nakulj and others added 12 commits October 8, 2026 11:25
An Error captured from a chained exception now carries each cause or
context in its message, so wrappers raised with `raise ... from exc`
no longer hide the underlying failure in reporters such as Backslash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ps-groscoe
ps-groscoe force-pushed the error-message-exception-chain branch from b310593 to f1e47f5 Compare October 8, 2026 18:25

@ps-groscoe ps-groscoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nakulj
nakulj merged commit 2a4c0f3 into main Oct 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants