Repository navigation
🐛 fix: update events body for new access render - #1011
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The Access SDK event contracts are unavailable and existing tests do not cover target or triggerPageType, leaving their types and requiredness unverified across legacy and new renderers.
No open issues 🎉
What changed in this PR
Updates access-event TypeScript interfaces to reflect payloads from the new paywall renderer while also describing legacy paywall metadata.
Changes:
- Adds
triggerPageTypeto four access events andtargettoAccessReadyEvent. - Adds optional usage counters and a custom reader ID to
AccessIdentityAvailableEvent. - Adds optional renderer-specific metadata to ready and paywall-seen events.
| File | Description |
|---|---|
src/types.ts |
Expands access-event interfaces with page, targeting, usage, and renderer metadata. |
Review effort: Balanced
dackmin
approved these changes
Nov 3, 2026
maximedasilva
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.