Repository navigation
Cr 1016 plcc ng demo migration - #11
Merged
Merged
Conversation
Record what plcc-ng-demo adds to the central tracker spec: a driver that reuses plcc-ng's converter at offset +800, the languages-ng duplicate rule applied to the three issues hand-copied into plcc-ng, and the switch-over in plcc-ng-demo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
plcc-ng-demo's tracker uses plcc-ng's format, so plcc_ng's converter now takes a Profile (project, offsets, GitHub URL, provenance) that defaults to plcc-ng, and plcc_ng_demo runs it at offset +800. A duplicates triage table marks an issue hand-copied into plcc-ng as Done + wontdo with the upstream CR's type and project plcc-ng, as for languages-ng; tracker_type moves to emit so both drivers share it. The triage file records the spec's three duplicates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The profile-based implementation is coherent, preserves existing driver behavior, and includes focused coverage for the new migration path.
0 open findings
What changed in this PR
Adds plcc-ng-demo migration support by reusing the plcc-ng converter through a repository-specific profile.
Changes:
- Adds and registers the plcc-ng-demo migration driver and triage data.
- Generalizes plcc-ng conversion and shared tracker-type lookup.
- Adds comprehensive driver tests and migration documentation.
| File | Description |
|---|---|
migrate/verify.py |
Documents the new driver option. |
migrate/tests/test_plcc_ng_demo.py |
Tests conversion, validation, links, and reruns. |
migrate/repo_links.py |
Documents demo link-rewriting support. |
migrate/plcc-ng-demo-triage.json |
Records upstream duplicate mappings. |
migrate/plcc_ng.py |
Introduces profile-based conversion. |
migrate/plcc_ng_demo.py |
Defines the demo migration driver. |
migrate/languages_ng.py |
Uses the shared tracker-type helper. |
migrate/emit.py |
Hosts the shared tracker-type lookup. |
migrate/drivers.py |
Registers the new driver. |
migrate/citations.py |
Documents the new driver option. |
dev-docs/tracker.md |
Documents demo migration tooling. |
dev-docs/specs/2026-10-11-plcc-ng-demo-migration-design.md |
Specifies migration decisions and verification. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.