Register the ceph-rgws validator - #2700
Merged
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
ideaship
marked this pull request as draft
September 15, 2026 19:14
The validator playbook validate-ceph-rgws.yml has shipped in osism/ansible-playbooks since 2023-05-24 but has never been invocable: osism/commands/validate.py builds the CLI's choices from VALIDATE_PLAYBOOKS, and ceph-rgws has never appeared in that dict in any of its forms. `osism validate ceph-rgws` fails with "invalid choice". Its siblings ceph-mons, ceph-mgrs and ceph-osds are registered and run, and the playbook follows their structure, ships its own report template and needs no other wiring. Add the missing entry. Assisted-by: Claude:claude-opus-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
ideaship
force-pushed
the
feat/register-ceph-rgws-validator
branch
from
September 15, 2026 19:53
a21d48e to
2cde37c
Compare
ideaship
marked this pull request as ready for review
September 16, 2026 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osism validate ceph-rgwsfails withinvalid choice: 'ceph-rgws'.osism/commands/validate.pybuilds the CLI'schoicesfromVALIDATE_PLAYBOOKS, andceph-rgwshas never appeared in that dict —in any of its forms (
VALIDATE_PLAYBOOK2ENVIRONMENT, added 2022-12-29with mons/mgrs/osds; renamed to
VALIDATE_PLAYBOOKS2023-01-17). So thevalidator has not been invocable since the playbook was added on
2023-05-24.
It is not a regression:
git log -S ceph-rgwsshows the only prioroccurrences of that string were in
MAP_ROLE2ENVIRONMENT, theosism applymapping for ceph-ansible's own role names, removed2023-02-05 — three months before the validator existed. Coincidence of
naming.
Its siblings
ceph-mons,ceph-mgrsandceph-osdsare registered andrun; the playbook follows their structure and ships its own report
template, so this entry is all the wiring it needs.
Merge order
This only opens the gate. In the years it could not be run the playbook
drifted badly enough that it fails immediately as it stands, so the
repair should land first or together with this:
Testing
With the companion PR applied, the validator was run against a live
full-profile cluster (Ceph 18.2.8 reef) and all three of its tests pass.
Its port test also correctly fails a deployment whose gateway listens on
7480 while 8081 is expected.
🤖 Generated with Claude Code