Repository navigation
fix(wggesucht): read title and address from the relaunched result cards - #503
Merged
orangecoding merged 1 commit intoNov 1, 2026
Merged
Conversation
WG-Gesucht renamed the classes on its result cards: the headline is now `.card-title-text` and the "2-Zimmer-Wohnung · Berlin Treptow · Straße" line is `.card-details-text`, formerly `.ad-title` and `.ad-subtitle`. Price, size and image still matched, so jobs kept finding listings, but every one of them came through with an empty title and no address. Without an address nothing could be geocoded, so WG-Gesucht listings never showed on the map and slipped past every area filter. The recorded search page predated the relaunch, which is why wgGesuchtSearchResults.test.js stayed green. Both fixtures are re-recorded; the byUrl and price tracking tests now pin an advert that is on the new search page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dedo1911
added a commit
to CappyT/fredy
that referenced
this pull request
Nov 2, 2026
Brings in upstream's wg-gesucht fix for the relaunched result cards (orangecoding#503). The merge had no conflicts and touches no fork file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WG-Gesucht renamed the classes on its result cards: the headline is now
.card-title-textand the "2-Zimmer-Wohnung · Berlin Treptow · Scheiblerstraße" line is.card-details-text(formerly.ad-titleand.ad-subtitle). Price, size and image still matched, so jobs kept finding listings, but every listing came through with an empty title and no address. Without an address nothing gets geocoded, so WG-Gesucht listings never appear on the map and pass every area filter, because listings without coordinates are kept.wgGesuchtSearchResults.test.jsstayed green only because the recorded search page predated the relaunch. With a freshly recorded page it fails ({ field: 'title', missing: 26 }), and with the two selectors changed it passes.Changes:
lib/provider/wgGesucht.js:title→.card-title-text,details/description→.card-details-texttest/testFixtures/wgGesucht.html,wgGesucht_detail.html: re-recorded (search page viayarn test:download-fixtures wgGesucht; detail page of an advert that is on that search page)test/provider/byUrl/wgGesucht.test.js,test/provider/priceTracking.test.js: now pin advert 14247424 (799 €, 20 m²) instead of 14245211, which is no longer on the recorded search pageSide note, not touched here: the detail page's
h1.detailed-view-titleincludes the English title of bilingual ads, sofetchListingByUrlreturns a longer title than the search card for those. That is why I picked a monolingual advert for the detail fixture.Related issue
none
AI disclosure (required)
ai:none- I wrote this myself. No AI generated code, text or commit messages.ai:assisted- AI helped with parts of it (autocomplete, refactoring, tests, docs). I reviewed and understand every line.ai:generated- AI produced most or all of this PR. I reviewed it, but it is largely machine written.Which AI: Claude Code, Claude Opus 5.5
How much: the whole diff (selector fix, fixture refresh, test updates) and this description; I found the bug in my own instance (WG-Gesucht listings without address/coordinates) and reviewed the changes.
Why: tracing why my WG-Gesucht listings had no coordinates led straight to the selectors, so the fix was quicker to do with the agent that found it.
Checklist
yarn test:offlinepasses (oryarn testif the change touches a live provider)yarn lintandyarn format:checkpass🤖 Generated with Claude Code