Skip to content

Bump maven-publish Java version from 11 to 21 - #5894

Merged
peterzhuamazon merged 2 commits into
opensearch-project:2.19from
shreyah963:2.19
Oct 16, 2026
Merged

peterzhuamazon merged 2 commits into
opensearch-project:2.19from
shreyah963:2.19

Conversation

@shreyah963

Copy link
Copy Markdown
Contributor

Description

Bump maven-publish Java version from 11 to 21

Related Issues

opensearch-project/opensearch-build#6469

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: shreyah963 <shreyab963@gmail.com>
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 41cf875)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
📝 TODO sections

🔀 No multiple PR themes
⚡ Recommended focus areas for review

Version Mismatch

The TODO comment indicates that the 2.x branch requires minimum JDK 11, not 21. Upgrading the maven-publish workflow to Java 21 may cause compatibility issues if the codebase or dependencies are not ready for Java 21. This could break the publishing process if the build or tests fail under Java 21, or if published artifacts are incompatible with Java 11 runtime environments that users may still be using.

java-version: 21  # TODO: 2.x is having minimum supported JDK at version 11, not 21.

Signed-off-by: shreyah963 <shreyab963@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 41cf875

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Verify Java version compatibility requirement

The TODO comment indicates a conflict between the Java version change and the
minimum supported JDK version. If version 2.x requires JDK 11 as minimum, using JDK
21 for publishing may create compatibility issues or mislead users about actual
requirements. Verify the intended minimum JDK version before proceeding.

.github/workflows/maven-publish.yml [26]

-java-version: 21  # TODO: 2.x is having minimum supported JDK at version 11, not 21.
+java-version: 11  # 2.x minimum supported JDK version is 11
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies a potential compatibility issue highlighted by the TODO comment. The PR changes java-version from 11 to 21, but the TODO explicitly states that 2.x requires minimum JDK 11, not 21. This warrants verification to ensure the change aligns with project requirements.

Medium

@peterzhuamazon
peterzhuamazon merged commit 5927f46 into opensearch-project:2.19 Oct 16, 2026
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants