Skip to content

The Jackson Jakarta migration adds the defaultView parameter to ProviderBase._configForWriting overrides - #1280

Merged
jkschneider merged 2 commits into
jakarta/provided-api-scopefrom
jakarta/jackson-provider-overrides
Oct 3, 2026
Merged

jkschneider merged 2 commits into
jakarta/provided-api-scopefrom
jakarta/jackson-provider-overrides

Conversation

@jkschneider

Copy link
Copy Markdown
Member

The Jakarta Jackson providers declare _configForWriting(ObjectMapper, Annotation[], Class<?> defaultView), so a ProviderBase subclass that overrode the two-argument javax method no longer compiled once JacksonJavaxToJakarta relocated the provider. New recipe JacksonProviderOverrides, run first in JacksonJavaxToJakarta, adds a Class<?> defaultView parameter, renamed if the name is taken, to such overrides and forwards it in their super._configForWriting call. Other calls to the two-argument method get the view appended as well: the new parameter inside a migrated override, null anywhere else.

Found by a team of coding agents reviewing a Moderne run of org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta over the 31 Arquillian repositories (run 20261003120559-YQoma). The issue is jackson-provider-override-signature in the run's io.moderne.RecipeIssues data table (1 row), and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:

The Jackson provider upgrade leaves an override using the removed two-argument ObjectMapper signature. (arquillian/continuous-enterprise-development, code/application/web/rest/core/src/main/java/org/cedj/geekseek/web/rest/core/provider/JSONProvider.java, recipe org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta)

Before:

// javax Jackson provider
protected JsonEndpointConfig _configForWriting(ObjectMapper m, Annotation[] a) { configure(m); return super._configForWriting(m, a); }

What the recipe produced:

// Jakarta Jackson provider
protected JsonEndpointConfig _configForWriting(ObjectMapper m, Annotation[] a) { configure(m); return super._configForWriting(m, a); }

Expected:

// Jakarta Jackson provider
protected JsonEndpointConfig _configForWriting(ObjectMapper m, Annotation[] a, Class<?> view) { configure(m); return super._configForWriting(m, a, view); }

Stacked on #1279 (17 of 19); merge that one first.

@jkschneider
jkschneider force-pushed the jakarta/jackson-provider-overrides branch from 342f5ae to 3b71f8e Compare October 3, 2026 22:26
@jkschneider
jkschneider added this pull request to stack #1283 October 3, 2026 22:39
@jkschneider
jkschneider merged commit ec720a6 into jakarta/reflective-type-names Oct 3, 2026
@jkschneider
jkschneider deleted the jakarta/jackson-provider-overrides branch October 3, 2026 22:41
jkschneider added a commit that referenced this pull request Oct 4, 2026
#1271)

* javax-reflective-names-retained: migrate runtime Jakarta type names

* maven-coordinate-literal-retained: migrate validation artifact lookups (#1272)

* weld-javax-provider-retained: align Weld core with Jakarta CDI (#1273)

* `JettyUpgradeEE9` also upgrades the other Jetty dependencies, the servlet packages and the Java version (#1274)

* jetty-ee9-java-baseline: align Jetty dependencies packages and Java baseline

* jetty-ee9-java-baseline: leave standalone Jetty utility dependencies unchanged

* jetty-ee9-java-baseline: require a direct dependency before upgrading Java

* `JacksonJavaxToJakarta` keeps newer Jackson versions and shared version properties when relocating artifacts (#1275)

* jackson-version-downgrade: preserve newer versions and shared properties

* jackson-shared-version-property-split: cover older shared Jackson versions

* The Jakarta JAXB migration keeps the `javax.xml.bind` API for Arquillian Recorder 1.x binaries (#1276)

* recorder-javax-jaxb-api-removed: retain the API needed by Recorder binaries

* recorder-javax-jaxb-api-removed: limit retention to external binaries after migration

* hibernate-validator-javax-provider-retained: migrate legacy validation providers (#1277)

* legacy-javaee-api-coordinate-retained: migrate legacy annotation EL and EJB aliases (#1278)

* The Jakarta migration keeps a provided API provided instead of adding it again in compile scope (#1279)

* cdi-provided-scope-promoted: preserve provided CDI API scope

* cdi-provided-scope-promoted: distinguish provided declarations from runtime APIs

* provided-api-scope-overwritten: preserve provided Mail API scope

* provided-api-scope-overwritten: preserve container API scopes across Jakarta migrations

* The Jackson Jakarta migration adds the `defaultView` parameter to `ProviderBase._configForWriting` overrides (#1280)

* jackson-provider-override-signature: forward the default view parameter

* jackson-provider-override-signature: update callers of migrated overrides

* invocation-context-get-constructor-missing: complete legacy decorators (#1281)

* jakarta-api-duplicates-platform: respect provided platform APIs (#1282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant