Upgrade Spring Boot 3 Maven parents to 3.5 in the Java 25 migration - #1254
Merged
Merged
Conversation
jkschneider
force-pushed
the
java25/spring-boot-parent
branch
from
October 3, 2026 15:51
8d704d4 to
ecc8e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring Boot 3.0 to 3.3 bundle a Spring Framework whose repackaged ASM cannot read Java 25 class files: after
UpgradeToJava25the application compiles, and its context tests fail withUnsupported class file major version 69. Three of the eight repositories in the run hit this. New compositeUpgradeSpringBootParentForJava25, part ofUpgradeToJava25: when the Maven parent isspring-boot-starter-parent3.x, upgrade it to 3.5.x withUpgradeParentVersion. It stays within Boot 3 (Boot 2 needs the Jakarta migration first) and never touches Boot 4. Gradle plugin and BOM imports are not covered here.Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.migrate.UpgradeToJava25over eight open-source repositories (run 20261003103223-WtyA8). The issue isspring-boot-java25-bytecodein the run'sio.moderne.RecipeIssuesdata table, and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:The migration retains Spring Boot 3.0.1 whose Spring ASM cannot read Java 25 bytecode. (
fhsinchy/movieist,pom.xml)Before:
What the recipe produced:
Expected:
Stacked on #1253 (5 of 9); merge that one first.