Skip to content

OPT: Combine cost/gradient into one - #169

Merged
rcjackson merged 2 commits into
openradar:mainfrom
rcjackson:consistency_fix
Oct 1, 2026
Merged

rcjackson merged 2 commits into
openradar:mainfrom
rcjackson:consistency_fix

Conversation

@rcjackson

@rcjackson rcjackson commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

I am currently trying to speed up PyDDA. The first optimization:

  • The cost function and gradient are now only called once on each iteration and combined.

Co-written by GPT-5.6 Luna

@rcjackson rcjackson changed the title OPT: Cache geometry angles and combine cost/gradient into one OPT: Combine cost/gradient into one Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.60305% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.56%. Comparing base (6572b81) to head (b3c3ec8).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pydda/cost_functions/cost_functions.py 81.96% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   70.57%   70.56%   -0.02%     
==========================================
  Files          32       32              
  Lines        5673     5793     +120     
==========================================
+ Hits         4004     4088      +84     
- Misses       1669     1705      +36     
Flag Coverage Δ
unittests 70.56% <91.60%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rcjackson
rcjackson merged commit 4f04b2e into openradar:main Oct 1, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant