Skip to content

FIX: restore SciPy cost-function consistency - #168

Merged
rcjackson merged 5 commits into
openradar:mainfrom
rcjackson:consistency_fix
Sep 29, 2026
Merged

rcjackson merged 5 commits into
openradar:mainfrom
rcjackson:consistency_fix

Conversation

@rcjackson

Copy link
Copy Markdown
Collaborator

This fix restores consistency between the smoothness gradient and cost functions, and fixes an issue in the vertical vorticity cost function with mismatched axes. Written with assistance from GPT-Luna 5.6.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.93069% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.57%. Comparing base (2219015) to head (6572b81).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pydda/cost_functions/_cost_functions_numpy.py 55.55% 32 Missing ⚠️
pydda/cost_functions/_cost_functions_jax.py 35.48% 20 Missing ⚠️
pydda/retrieval/wind_retrieve.py 42.85% 20 Missing ⚠️
pydda/cost_functions/cost_functions.py 65.11% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   71.28%   70.57%   -0.71%     
==========================================
  Files          32       32              
  Lines        5509     5673     +164     
==========================================
+ Hits         3927     4004      +77     
- Misses       1582     1669      +87     
Flag Coverage Δ
unittests 70.57% <56.93%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rcjackson
rcjackson merged commit 7935096 into openradar:main Sep 29, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant